Skip to content

fix av_image_alloc alignment && check allocation error #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2025
Merged

fix av_image_alloc alignment && check allocation error #987

merged 1 commit into from
May 23, 2025

Conversation

ArmstrongCN
Copy link
Contributor

  • Add memory allocation error handling to prevent memory corruption
  • Libav requires proper alignment for some format.
  • Use 32-byte alignment for better SIMD performance and libav compatibility
    The changes ensure proper error handling when av_image_alloc() fails and optimize memory alignment for SIMD instructions.

@jonoomph
Copy link
Member

Fix av_image_alloc alignment && check allocation error

@jonoomph jonoomph changed the base branch from develop to align-memory-32 May 23, 2025 23:13
@jonoomph jonoomph merged commit 4983a45 into OpenShot:align-memory-32 May 23, 2025
1 check passed
@jonoomph
Copy link
Member

Thanks for your contribution and sorry for the delay. I'm going to merge this into a new branch, and make some similar changes to our macros, so we apply this everywhere in the code we AV_ALLOCATE_IMAGE.

@jonoomph jonoomph mentioned this pull request May 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArmstrongCN @jonoomph